Discussion:
IE errors in getViewportDimensions
David Barnett
2008-11-17 23:19:08 UTC
Permalink
Hi guys,

I found a somewhat obscure bug in getViewportDimensions that appears in IE
when using TurboFancyFlash.

The problem is that the check whether
MochiKit.DOM._document.body.parentElement.ClientWidth
exists will error out if
MochiKit.DOM._document.body
doesn't exist. TurboFancyFlash makes that happen in IE by calling
getViewportDimensions from the HEAD tag.

I've attached a patch against the latest SVN of MochiKit. I've also sent the
patch to the Chris Arndt (the TurboFancyFlash creator) since TFF bundles a
version of MochiKit.

David

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "MochiKit" group.
To post to this group, send email to ***@googlegroups.com
To unsubscribe from this group, send email to mochikit+***@googlegroups.com
For more options, visit this group at http://groups.google.com/group/mochikit?hl=en
-~----------~----~----~----~------~----~------~--~---
Per Cederberg
2008-11-18 09:40:08 UTC
Permalink
Thanks for a great bug report and patch, David!

It has been applied in r1466 and will also show up in 1.4.2 (eventually).

Cheers,

/Per
Post by David Barnett
Hi guys,
I found a somewhat obscure bug in getViewportDimensions that appears in IE
when using TurboFancyFlash.
The problem is that the check whether
MochiKit.DOM._document.body.parentElement.ClientWidth
exists will error out if
MochiKit.DOM._document.body
doesn't exist. TurboFancyFlash makes that happen in IE by calling
getViewportDimensions from the HEAD tag.
I've attached a patch against the latest SVN of MochiKit. I've also sent the
patch to the Chris Arndt (the TurboFancyFlash creator) since TFF bundles a
version of MochiKit.
David
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "MochiKit" group.
To post to this group, send email to ***@googlegroups.com
To unsubscribe from this group, send email to mochikit+***@googlegroups.com
For more options, visit this group at http://groups.google.com/group/mochikit?hl=en
-~----------~----~----~----~------~----~------~--~---

Loading...